Repository navigation
Conversation
Compare both membership operators with empty and null-containing arrays against npm Zero across every Postgres adapter. Exercise two callbacks sharing the same relationship base in one query. These deterministic cases cover the four upstream branches missed by the generated examples in dependency PR CI.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merging this PR will improve performance by 13.14%2 warnings
Performance Changes
Tip Curious why performance improved? Comment Comparing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 658617dfa5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dependency PR CI passed all 795 tests but failed the compatibility proof because generated inputs missed four upstream branches:
NOT INcompilation and repeated relationship-base lookup. Pin deterministic differential cases so changing Hypothesis draws cannot remove this evidence.The tests compare
INandNOT INwith empty, nonempty and null-containing arrays against npm Zero 1.11.4 across all four real Postgres adapters. A query with twoexistscallbacks compares reuse of one relationship base. Production code and coverage exclusions are unchanged.Validation: 25 focused tests pass with Node 24.22.3 and isolated Postgres. The existing V8/c8 remapper reports no remaining gaps at the four previously uncovered branch locations. Ruff, focused ty and diff checks pass. Independent Codex review found no correctness issue. Full compatibility coverage remains a CI gate. UltraCode is unavailable in this environment.
Refs #62: fixes the missing deterministic compatibility evidence; the dependency update remains a separate PR.
Refs #57: the same compatibility proof will run again after this lands; its other failed checks still require current verification.
Baseline failure: https://github.com/agent-labs-dev/zero-python/actions/runs/43293670439/job/131446161904
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.