Skip to content

test: pin membership and relationship compatibility cases - #63

Open
cjber wants to merge 1 commit into
mainfrom
cb/compat-coverage
Open

cjber wants to merge 1 commit into
mainfrom
cb/compat-coverage

Conversation

@cjber

@cjber cjber commented Nov 15, 2026 •

Copy link
Copy Markdown

Dependency PR CI passed all 795 tests but failed the compatibility proof because generated inputs missed four upstream branches: NOT IN compilation and repeated relationship-base lookup. Pin deterministic differential cases so changing Hypothesis draws cannot remove this evidence.

The tests compare IN and NOT IN with empty, nonempty and null-containing arrays against npm Zero 1.11.4 across all four real Postgres adapters. A query with two exists callbacks compares reuse of one relationship base. Production code and coverage exclusions are unchanged.

Validation: 25 focused tests pass with Node 24.22.3 and isolated Postgres. The existing V8/c8 remapper reports no remaining gaps at the four previously uncovered branch locations. Ruff, focused ty and diff checks pass. Independent Codex review found no correctness issue. Full compatibility coverage remains a CI gate. UltraCode is unavailable in this environment.

Refs #62: fixes the missing deterministic compatibility evidence; the dependency update remains a separate PR.
Refs #57: the same compatibility proof will run again after this lands; its other failed checks still require current verification.

Baseline failure: https://github.com/agent-labs-dev/zero-python/actions/runs/43293670439/job/131446161904


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Compare both membership operators with empty and null-containing arrays
against npm Zero across every Postgres adapter. Exercise two callbacks
sharing the same relationship base in one query.

These deterministic cases cover the four upstream branches missed by the
generated examples in dependency PR CI.
@cjber
cjber requested a review from jnsdls as a code owner November 15, 2026 20:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T20:11:17.372476Z 658617d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codspeed

codspeed Bot commented Nov 15, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 13.14%

2 warnings

⚠️ 19 benchmarks with a significant change ran on different hardware

Their base and head results were measured on machines with a different CPU, core count or memory, so the changes might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚠️ 19 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 19 improved benchmarks
✅ 27 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_cpu[mutate_cpu.put.n100] 23.4 ms 19.8 ms +17.83%
⚡ test_cpu[query_json.simple.b100] 16.2 ms 14 ms +15.47%
⚡ test_cpu[z2s.complex] 1.3 ms 1.1 ms +15.03%
⚡ test_cpu[query.complex.b100] 49.6 ms 43.2 ms +14.95%
⚡ test_cpu[mutate_cpu.crud.n100] 55.6 ms 48.4 ms +14.91%
⚡ test_cpu[map.simple] 108.3 µs 94.3 µs +14.79%
⚡ test_cpu[query_json.complex.b100] 58.3 ms 50.8 ms +14.73%
⚡ test_cpu[z2s.related] 609.2 µs 531.9 µs +14.53%
⚡ test_cpu[query.simple.b100] 11.1 ms 9.7 ms +14.36%
⚡ test_cpu[parse.transform.q1000] 78.2 ms 69.4 ms +12.75%
⚡ test_cpu[build.simple] 94.3 µs 84.1 µs +12.07%
⚡ test_cpu[map.complex] 272.2 µs 243.1 µs +11.96%
⚡ test_cpu[mutate_cpu.crud.n1] 1,053.6 µs 943.5 µs +11.67%
⚡ test_cpu[build.complex] 510.8 µs 458.9 µs +11.31%
⚡ test_cpu[query.simple.b1] 345.9 µs 311.2 µs +11.14%
⚡ test_cpu[query_json.simple.b1] 438 µs 394.9 µs +10.9%
⚡ test_cpu[query_json.complex.b1] 876.1 µs 791.1 µs +10.75%
⚡ test_cpu[parse_json.transform.q1000] 55.3 ms 50 ms +10.49%
⚡ test_cpu[parse_json.push.m1000] 44.3 ms 40.1 ms +10.42%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cb/compat-coverage (658617d) with main (1e7f6a6)

Open in CodSpeed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 658617dfa5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/wire/test_query.py Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant